yireo / Yireo_NextGenImages

45 stars 28 forks source link

Bug: Not all HTML formatting is supported #67

Closed dennisvanderweide closed 1 year ago

dennisvanderweide commented 1 year ago

We had some problems with img tags not being replaced with picture tags so I did some testing.

I discovered that images formatted like this

<img
    class="object-contain duration-300 hover:scale-105"
    loading="lazy"
    x-data=""
    @update-gallery-<?= (int) $productId ?>.window="$el.src = event.detail"
    alt="<?= $escaper->escapeHtmlAttr($productImage->getLabel()) ?>"
    title="<?= $escaper->escapeHtmlAttr($productImage->getLabel()) ?>"
    src="<?= $escaper->escapeUrl($productImage->getImageUrl()) ?>"
    width="<?= $escaper->escapeHtmlAttr($productImage->getWidth()) ?>"
    height="<?= $escaper->escapeHtmlAttr($productImage->getHeight()) ?>"
/>

are not being replaced with picture tags, but simply having any attribute on the same line as the img tag does replace it.

<img class="object-contain duration-300 hover:scale-105"
    loading="lazy"
    x-data=""
    @update-gallery-<?= (int) $productId ?>.window="$el.src = event.detail"
    alt="<?= $escaper->escapeHtmlAttr($productImage->getLabel()) ?>"
    title="<?= $escaper->escapeHtmlAttr($productImage->getLabel()) ?>"
    src="<?= $escaper->escapeUrl($productImage->getImageUrl()) ?>"
    width="<?= $escaper->escapeHtmlAttr($productImage->getWidth()) ?>"
    height="<?= $escaper->escapeHtmlAttr($productImage->getHeight()) ?>"
/>
jissereitsma commented 1 year ago

This should be fixed in the latest releases. Feel free to reopen this ticket if - after upgrading - this problem persists.

dennisvanderweide commented 1 year ago

Great, thanks