search

yireo / Yireo_NextGenImages

44 stars 26 forks source link

Error after upgrading to latest version(s) #70

Closed onlinemusketeers closed 4 months ago

onlinemusketeers commented 9 months ago

Hi Jisse,

I get a conflict after updating the extensions. Any thoughts about what could have go wrong? Tnx!

1 exception(s): Exception #0 (Exception): Warning: Declaration of

Hyva\YireoNextGenImages\Model\AlpinePictureFactory::create(Yireo\NextGenImages\Image\Image $originalImage, array $images, string $htmlTag, bool $isDataSrc = false): Yireo\NextGenImages\Block\Picture

should be compatible with

Yireo\NextGenImages\Block\PictureFactory::create(Yireo\NextGenImages\Image\Image $originalImage, array $images, string $htmlTag, string $srcAttribute = 'src'): Yireo\NextGenImages\Block\Picture in /magento/vendor/hyva-themes/magento2-yireo-next-gen-images/src/Model/AlpinePictureFactory.php on line 57

jissereitsma commented 9 months ago

Did you make sure to remove the Hyva compatibility module, because the main reason for upgrading is that compabitility is built into the core module already?

onlinemusketeers commented 9 months ago

That did the job! Thanks a lot Jisse!