search

yireo / Yireo_NextGenImages

44 stars 26 forks source link

Check for image extension in entire url instead of only at the end #72

Closed jesperingels closed 4 months ago

jesperingels commented 9 months ago

In Magento you can have parameters at the end of your product image url. You can find this functionality here: '\Magento\Catalog\Model\View\Asset\Image::getUrlWithTransformationParameters'

In the Yireo_NextGenImages module we currently check for an image-extension ('.jpg', '.jpeg', '.png') at the end of the url. But having an image-extension not at the end of your url should also be valid in this case.

jissereitsma commented 4 months ago

Sorry for the long delay in this. After all, I think this addition is a good thing to have.