search

yireo / Yireo_NextGenImages

44 stars 26 forks source link

Color swatches are not working for me on project using Hyva #74

Open sebfie opened 9 months ago

sebfie commented 9 months ago

Hello,

I created a new Magento 2.4.4 project with Hyva and installed your extension: 

"yireo/magento2-next-gen-images": "^0.5.0",
"yireo/magento2-webp2": "^0.13.3"
Alpinejs : 3.12.3
Hyva theme : 1.3.2

And Image switching from Image Swatch is not working :

https://share.cleanshot.com/9Hp9hXHq

If I replace vendor/yireo/magento2-next-gen-images/view/frontend/templates/picture.phtml with the content of vendor/yireo/magento2-next-gen-images/view/frontend/templates/hyva/picture.phtml it's working :

https://share.cleanshot.com/xXmfDwtW

I will make a PR for that

jissereitsma commented 3 months ago

Could you specifically mention which part of the hyva/picture.phtml makes it work for you? In current versions of this module, the file is actually no longer there. So perhaps this has been resolved already.