search

yireo / Yireo_Webp2

Magento 2 module to add WebP support to Magento 2
Open Software License 3.0
194 stars 54 forks source link

Using js native _determineProductData function #120

Closed Amadeco closed 2 years ago

Amadeco commented 2 years ago

Good evening @jissereitsma !

I think we can using _determineProductData function from Magento's swatch-renderer : https://github.com/magento/magento2/blob/fde55517ff5bc79aacc64d4c08411e0112356e17/app/code/Magento/Swatches/view/base/web/js/swatch-renderer.js#L382

Can you take a look ?

jissereitsma commented 2 years ago

Sorry for the long delay. Yes, this sounds like a better approach. I'm merging right away.