Issue with https vs http

[sunilit42]

https://github.com/yireo/Yireo_NextGenImages/blob/master/Util/UrlConvertor.php#L110

creating issue with https vs http

as that line convert into http and getMediaUrl and static url getting with https so no condition matching so no image convert into webp image

https://github.com/yireo/Yireo_NextGenImages/commit/665e4f442e7c3893b02353580d44056cfce70479 i think this code change creating issue

[jissereitsma]

Thanks for spotting this. I've released a new version 0.3.7 right away. Note that this issue could / should have created on the other repo instead, because it was a bug with that extension, not this one.

Feel free to re-open this issue, if it is not fixed yet.

[haihv433]

Hi @jissereitsma

I faced the same as @sunilit42 posted here

Everyone using HTTPS will can not able to place webp file

Pls have a fix

Thanks

[jissereitsma]

@haihv433 So did you upgrade (as the fix that I mentioned to be releasing, was released when posting earlier)?

[jissereitsma]

Feel free to re-open this issue, if it is not fixed yet with the newest release.

[haihv433]

I downgraded to previous version to fix this since this quite challenging when this version was not stable yet Thanks btw I will re-check soon

[sunilit42]

@jissereitsma still same one issue https://github.com/yireo/Yireo_NextGenImages/blob/master/Util/UrlConvertor.php#L140 https vs http issue

[jissereitsma]

Thanks. The same fix is now applied to the function getBaseUrl as well, so that should overcome this issue. Version is 0.3.9.

[sunilit42]

@jissereitsma Thanks But there are too many issue with plugin https://github.com/yireo/Yireo_NextGenImages/issues/16#issuecomment-966884156

I think html parser is good idea

[jissereitsma]

@sunilit42 There are also many people that are using this plugin without issues. I have to admit that other issues are open too long. But referring to them to put pressure doesn't help. If you can collaborate on fixing all issues, then please do. Otherwise, except that I'm just doing this on voluntary basis, spending hours and hours, without asking money.

I assume the current issue is fixed and this ticket can be closed again.

[sunilit42]

@jissereitsma i will help you sir if i can do it

• do you want to use getElementsByTagName for image replacement or you want to continue with regex

[jissereitsma]

@sunilit42 I think this issue closed, so let's discuss progress on other issues with those other issues. Version 0.3.10 includes fixes for https://github.com/yireo/Yireo_NextGenImages/issues/16 but I found the discussion a bit like "hey, dropping regex and going for DOMDocument" to be less productive. Let's discuss specific improvements in the issues that are relevant and in the way that it moves things forward.

[sunilit42]

@jissereitsma ya i see and works fine one more issue found while testing

• minicart image not showing webp image
• background css image ( i know that is not possible)

[jissereitsma]

This issue is really really closed. Could you report new problems by creating new issues? Otherwise this open source project becomes impossible to manage.