yireo / Yireo_Webp2

Magento 2 module to add WebP support to Magento 2
Open Software License 3.0
194 stars 54 forks source link

Yireo_Webp2 install but no changes display #126

Closed magentoprasad closed 1 year ago

magentoprasad commented 2 years ago

We activated Webp2 but it still img tag showing and .jpg or .png files for products Magento V 2.4.4 gd library is enabled on server which should support imagewebp : as per server provider.

jissereitsma commented 2 years ago

Thanks for posting. Which steps did you already make to debug this? There is an entire SUPPORT.md document with hints and obviously that's useful to take into account here.

magentoprasad commented 2 years ago

All steps as mentioned in document please check screenshot PHP Version 7.4.30 GD Support | enabled GD Version | bundled (2.1.0 compatible)

webP-image

image

jissereitsma commented 2 years ago

Thanks. I'm not sure why the posting on the phpinfo was needed. As for the DI info, I'm not sure why you are posting this. But if you were suspecting that the DI information of NextGenImages (https://github.com/yireo/Yireo_NextGenImages/blob/master/etc/frontend/di.xml) is missing, then you could be right. But you didn't share all items suggested in the SUPPORT.md yet, so I trust the solution is there that you missed some instruction on how to install and enable either NextGenImages or WebP.

magentoprasad commented 2 years ago

Hi, PHP info just for information what we are using and what are the settings in PHP. Composer version 2.3.9 Have you tested this after flushing all caches, especially the Full Page Cache? : Yes Are you testing this in the Developer Mode or in the Production Mode? : Default Could you supply a URL to a live demo? : https://www.morphysheldon.com/ Could you please supply a snapshot of the HTML source of a product page? : https://www.morphysheldon.com/no-limits-printed-half-t-shirt yirenextgenimge-set yireo-webP2-set I try to provide you all information as per my understanding. Thank you.

jissereitsma commented 2 years ago

Actually, the Default Mode is something I can't support unless you are a Magento expert that knows everything about DI compile. Could you please switch to Developer Mode, if you are installing extensions? Installing extensions without doing anything about the DI compilation in the Default Mode, tells that you are missing pieces on how Magento works.

magentoprasad commented 1 year ago

Hi we switch to developer mode but still we are not recognized the issue.
Also webP is enabled in php settings. What is next step to resolved the issue?

image

jissereitsma commented 1 year ago

Thanks. But I'm unable to troubleshoot this any further. You keep repeating that command while I don't know what you want to proof with it. Yet you ask me to troubleshoot the extension. I'm not sure how to help. Please note also that the command you are showing is totally unrelated to my extensions.

magentoprasad commented 1 year ago

hello I am not posting this command to proof anything please don't misunderstand after switching to developer mode I thought we will get something hint to resolve issue. I am just following your support.md if the WebP configuration section is showing in the backend, but the HTML source in the frontend is not modified, please send the output of the command bin/magento dev:di:info "\Magento\Framework\View\LayoutInterface".

Again WebP is new for me for so I am not able to debug actual issue. Please don't take in wrong way.

jissereitsma commented 1 year ago

I understand that you mean no harm. But when reporting the issue, I'm still not hearing you say the obvious. For instance, disable my modules and check the DI output again. Are you seeing the same DI error still? Then your Magento instance is broken.

magentoprasad commented 1 year ago

Hello we are getting exception as following for image converter webp-convert-www morphysheldon can you please suggest / guide solution ?

jissereitsma commented 1 year ago

Unfortunately, I'm not going to jump forth and back before making sure we are on the same page. Could you first explain why you are not addressing the first issue anymore? If it was solved, and you were asking me for support initially, it is fair to get feedback on what you fixed? What was wrong with this extension in the first place?

magentoprasad commented 1 year ago

OK. For first issue I reinstall the module. as result for some images it works for some it not works some time browser takes time show result. so I conclude it for my self it works for new added images not for already images ( its totally my assumption Please don't miss understand ) to move ahead to completion of project I continue as it is for now. Today when try to add block for footer then he face above error page. so for now he remove that block then page load perfectly.

Thank you for your prompt reply every time. it helps us to get issue solved in fast way.

jissereitsma commented 1 year ago

Ok, but you solved the first issue - the one that is mentioned in the title of this page - by reinstalling this module. The module itself did not change. So is it logical to assume that something changed in your own environment (caching, DI compilation, developer mode, permissions) so this suddenly worked? If so, it is important to take note of that, because apparently the troubleshooting needed to take place on the environment, not this module - and therefore the entire support thread here was less applicable.

For the new issue, could you first open up an issue? That's how GitHub Issues work: A new issue for each new issue. Then we close this issue because apparently it was solved for unknown reason.

magentoprasad commented 1 year ago

we reinstall in same environment ( default). Yes we can close this issue. Thank You.