search

yireo / Yireo_Webp2

Magento 2 module to add WebP support to Magento 2
Open Software License 3.0
194 stars 54 forks source link

Uncaught Exception #127

Closed jakegore closed 1 year ago

jakegore commented 1 year ago

Hi @jissereitsma!

We came across an issue on one of our sites where there was an uncaught exception that was causing the site to unexpectedly crash. In the package rosell-dk/webp-convert, the WebPConvert\Exceptions\InvalidInputException is thrown under multiple conditions but these are not checked for in this module. I created a patch for our site that checked for this exception and it fixed the issue. I thought I would open a PR with this change to hopefully prevent others from facing this issue.

jissereitsma commented 1 year ago

Thanks, great catch! I'll merge and release right away!