504 page when no review with product page

yireo / Yireo_Webp2

Magento 2 module to add WebP support to Magento 2

Open Software License 3.0

197 stars 57 forks source link

504 page when no review with product page #129

Closed sunilit42 closed 1 year ago

sunilit42 commented 2 years ago

https://github.com/yireo/Yireo_NextGenImages/blob/master/Observer/ReplaceBlockHtml.php#L73

I think we need to add to condition if html contain sting then do that stuff, otherwise getting error

jissereitsma commented 2 years ago

Could you please comment on what causes you to suggest this change? Is there an error or a warning? For which specific page would the transport of an HTML event when outputting a Magento page be blank?

sunilit42 commented 2 years ago

[2022-08-01 05:34:47] report.CRITICAL: Warning: DOMDocument::loadHTML(): Empty string supplied as input in /srv/public_html/vendor/yireo/magento2-next-gen-images/Util/HtmlReplacer.php on line 139

This is happen for ajax review loading on product page
open any product page, that does not contain any review
you will see this error loadHTML(): Empty string supplied as input into log file

jissereitsma commented 2 years ago

Could you confirm the version you are using?

sunilit42 commented 2 years ago

"name": "yireo/magento2-webp2", "version": "0.12.1",

jissereitsma commented 2 years ago

Thanks. Could you upgrade to the latest versions of NextGenImages and WebP2 to see if this fixes your issue? It would be a bit silly to troubleshoot issues that are already fixed.

jissereitsma commented 1 year ago

I'm closing this ticket due to inactivity. Feel free to reopen if needed.