search

yireo / Yireo_Webp2

Magento 2 module to add WebP support to Magento 2
Open Software License 3.0
197 stars 57 forks source link

Error with magepack bundle #130

Closed walkwizus closed 2 years ago

walkwizus commented 2 years ago

Hi,

When I'm using magepack to bundle all JS, there are an error due to this file: https://github.com/yireo/Yireo_Webp2/blob/master/view/frontend/web/js/add-webp-class-to-body.js

The semicolon is missing and it break on the frontend. Can you add it ? Can you add an end of file too ? Impossible to patch it without this character.

Thanks !

jissereitsma commented 2 years ago

Thanks for reporting this. I've released a new version with this fix right away.

By the way, do you know you can edit a file on GitHub and create a Pull Request from it right away? It makes the process of creating Pull Requests dead-simple, and by doing it that way, everyone knows which code you are referring to right away.

walkwizus commented 2 years ago

Thanks ! Next time I do that !

walkwizus commented 2 years ago

Hi !

I don't see the modification in the last release, just an update in composer.json and release note. I do the PR ?

Thanks

jissereitsma commented 2 years ago

The following comparison shows all differences between 0.12.2 and 0.12.3: https://github.com/yireo/Yireo_Webp2/compare/0.12.2...0.12.3 It includes the semicolon. Could you double-check which version you are using and which files is not confirmed to be modified?