yireo / Yireo_Webp2

Magento 2 module to add WebP support to Magento 2
Open Software License 3.0
194 stars 54 forks source link

Setting convert images to "no" doesn't do anything #132

Closed CyberSecutor closed 1 year ago

CyberSecutor commented 1 year ago

When setting the "convert images" option in NextGenImages to No, it keeps converting the images to webp.

image

When looking at the code, the config setting allowImageCreation() is never used.

    public function allowImageCreation(): bool
    {
        return (bool)$this->getValue('yireo_nextgenimages/settings/convert_images');
    }
jissereitsma commented 1 year ago

Good point. This was indeed added but never implemented. I've implemented the method in the WebP module version 0.12.4, even though I think it requires further finetuning.

I'll close this issue because the feature is now there. But if you bump into issues with it, do feel free to reopen this ticket again.

CyberSecutor commented 1 year ago

Thank you Jisse,

I've tested it and it works as expected.