yireo / Yireo_Webp2

Magento 2 module to add WebP support to Magento 2
Open Software License 3.0
194 stars 54 forks source link

Media cache directory path - It doesn't work even after setting it up ! #154

Closed hgati closed 10 months ago

hgati commented 10 months ago

admin panel setting

On Yireo_NextGenImages module https://github.com/yireo/Yireo_NextGenImages/blob/8e060babaa9a48380ed09e7ecd7c2b70bf13ca7f/etc/adminhtml/system.xml#L56C24-L56C24

system.xml

config.xml

It seems to be caused by the difference in the 'config key' between 'system.xml' and 'config.xml'

jissereitsma commented 10 months ago

Thanks for spotting this. Note that this is an issue not in the Yireo Webp2 module (this repository) but the Yireo NextGenImages module. The variable name cache_directory_path is a bit duplicate anyway, because a directory is kind of the same as a path. It will be fixed in the next release: https://github.com/yireo/Yireo_NextGenImages/commit/c1f26f7f9fcc0cb949fa55a18a730ad5caf97b0a