While trying to figure out after a big update of dependencies why quality setting of yireo's webp2 module no longer seems to work, I discovered some things.
Currently this yireo webp2 module (at version 0.13.5) uses the options:
quality - which is hardcoded set to "auto"
max-quality - based on backoffice configuration
encoding - based on backoffice configuration
convertor - based on backoffice configuration
Problems with these options:
quality with setting "auto" is deprecated in the rosell module
max-quality is deprecated in the rosell module
the quality value from backoffice in yireo's module is no longer taken into account, however the Magento config Advanced > System > Images Upload Configuration > Quality is used instead "by accident" I guess, for jpeg => webp conversion because the new version of the rosell module uses the minimum quality amount between the quality from the jpeg or the "quality" setting defined (so no longer the "max-quality")
Proposal:
bump the minimum composer constraint version for rosell-dk/webp-convert to at least ^2.6 or maybe even higher?
rework the logic, so that the quality configuration value is now passed on to the "quality" option and not to the "max-quality" option
consider adding a config option to set the new "auto-limit" option on or off
It's a bit annoying that rosell-dk/webp-convert released this in version 2.6.0 and not in a new major version 3.0.0 for example, but they added some fallback logic, which "kinda" keeps some kind of backwards compatibility promises, but not entirely...
Also kind of strange nobody else seemed to have noticed this, version 2.6.0 was already released 3 years ago.
This is pretty complicated stuff, I hope I didn't make a mistake in my explanation here and it's a bit clear what I'm trying to say
While trying to figure out after a big update of dependencies why quality setting of yireo's webp2 module no longer seems to work, I discovered some things.
Some links:
Currently this yireo webp2 module (at version 0.13.5) uses the options:
Problems with these options:
Proposal:
rosell-dk/webp-convertto at least^2.6or maybe even higher?It's a bit annoying that rosell-dk/webp-convert released this in version 2.6.0 and not in a new major version 3.0.0 for example, but they added some fallback logic, which "kinda" keeps some kind of backwards compatibility promises, but not entirely... Also kind of strange nobody else seemed to have noticed this, version 2.6.0 was already released 3 years ago.
This is pretty complicated stuff, I hope I didn't make a mistake in my explanation here and it's a bit clear what I'm trying to say