search

yireo / Yireo_Webp2

Magento 2 module to add WebP support to Magento 2
Open Software License 3.0
197 stars 57 forks source link

webp class in body and skip changing CDN images #25

Closed itsazzad closed 1 year ago

jissereitsma commented 4 years ago

Thanks for the commit. It seems however that your commit is based on a previous version of WebP and is therefore some fixes that were added lately. Mainly this commit: https://github.com/yireo/Yireo_Webp2/commit/26907cfc4a30fd1ee65cd413d88eb8a0db895f79#diff-409c1892b68cb394799262ac57f6d4f1 Could you please apply the PR to the latest release instead? Also, could you make sure to inject variables without an underscore? It is not a best practice to inject a variable $_storeManager, because $storeManager serves the same purpose.

jissereitsma commented 1 year ago

Unfortunately, it is 3 years later, so unfortunately the sources are far too different to make sense of. I'll close this PR as of yet.