yireo / Yireo_Webp2

Magento 2 module to add WebP support to Magento 2
Open Software License 3.0
197 stars 57 forks source link

Fix the 'Fallback to JQueryUI Compat activated' for Magento version 2.3.3 and above #50

Closed toan-tam closed 3 years ago

toan-tam commented 3 years ago

Issue:

Fallback to JQueryUI Compat activated. Your store is missing a dependency for a jQueryUI widget. Identifying and addressing the dependency will drastically improve the performance of your site.

The reason the issue occurs is that we inject the 'jquery/ui' as a dependency to our mixin and from Magento 2.3.3, jquery UI is restructured and causes the issue.

Proposal solution:

Reference doc: https://devdocs.magento.com/guides/v2.4/javascript-dev-guide/javascript/js_mixins.html

toan-tam commented 3 years ago

Hi @jissereitsma, Can you help review this PR?

jissereitsma commented 3 years ago

Thanks, it is a small change but very important indeed - as you point out. The involved JS file originates from a third party PR and I can see that in the past some jQuery UI logic was needed. But currently, there is not, which makes your PR completely needed. Thanks again! Merging right away.