search

yireo / magento2-replace-all

Meta-package to replace all optional Magento 2 modules
129 stars 32 forks source link

magento 2.4.0 - elasticsearch 5/6 deprecated #16

Closed magenx closed 4 years ago

magenx commented 4 years ago

as ElasticSearch is up to version 7.x only, it is better to remove:

magento/module-elasticsearch
magento/module-elasticsearch-6
jissereitsma commented 4 years ago

Thanks, adding this right away.

jissereitsma commented 4 years ago

Actually, this turned out to be a bad idea. The module magento/module-elasticsearch is needed for the DI compilation of magento/module-elasticsearch7. And likewise, magento/module-elasticsearch6 is still quite a bit used by the community.

magenx commented 4 years ago

i love magento elasticsearch depends on elasticsearch to make elasticsearch work, but.... it is deprecated...

https://devdocs.magento.com/guides/v2.3/mrg/ce/Elasticsearch.html https://devdocs.magento.com/guides/v2.3/mrg/ce/Elasticsearch7.html

magentoelk

jissereitsma commented 4 years ago

I know. It apparently means that there is a difference between the ElasticSearch module (which supports both the deprecated options plus the interfaces needed for the other modules) and the actual selection for a search engine.

magenx commented 4 years ago

sure... this is exactly how it supposed to work 🥇

magenx commented 4 years ago

magento 2.4.0 fresh install

magentoelk

jissereitsma commented 4 years ago

Again, I understand - you don't need to proof this, I already understood. But deprecated does not mean that this change should be enforced upon everyone.

I assume you are well aware of the fact that this replacement package is a kickstart for anyone willing to remove packages using an undocumented hack in composer. But also note that if you disagree with anything here, the simple and adequate solution is to copy the replace sections to your own project and replace things there. In short, if you want to remove the ES and ES6 module, you can do so by adding the replacements to your own composer project. But I do not think it is a wise idea to enforce this change upon the other users of this package. Nothing more, nothing less.