Closed cemulate closed 6 years ago
Apologies for the delay. Here are some thoughts:
keyup
rather than on keydown
accessibility-wise. The keyboard shortcut for 'Remove Arrow' is also in keyup
; we should probably keep them in the same place.No prob on the delay.
I like your idea about "up" and "down" considering that matches the icons. I've also moved all that I can to keyup
. Unfortunately, the Enter
to edit cannot be on keyup
, since if you're editing the label the Enter press that triggers form submission does so on keydown
which means you immediately open the edit label again on keyup
(if you have a better idea to handle that, let me know).
My logic for the label movement just comes from using WASD as the left set of arrows - most peoples' hands will be resting there anyway, and it seemed like a natural choice for left-middle-right.
Just realized I forgot to hint the buttons, I'll do that real quick as well.
Thank you very much!
Clicking the far away buttons for changing edge properties was driving me crazy!
I've implemented basic keyboard navigation for when you have an edge selected. If you have better ideas about what keys should be used, I'd love to hear them, but the basic idea is there.
I've renamed
data
inApp
to be a little more descriptive and match the corresponding stuff I added inProperties