yishn / tikzcd-editor

A simple visual editor for creating commutative diagrams.
https://tikzcd.yichuanshen.de/
MIT License
1.86k stars 100 forks source link

Can't input more than a character on Safari #41

Open konn opened 5 years ago

konn commented 5 years ago

On Safari 12.1, one cannot input more than one character for each label, and text mouse-cursor doesn't appear at all.

How To Reproduce

  1. Open the official demo page.
  2. Double-click any empty node
  3. Although text mouse-cursor or text cursor don't appear, one can input a single character.
  4. Then, the focus seems disabled and any additional key event goes nowhere.
  5. If one re-double click the same node, one can replace the label with another single character by pushing any single key, but cannot append/prepend characters to the existing label.

Environment

ericelliott commented 4 years ago

This is working for me, now.

konn commented 4 years ago

This hasn't been fixed yet in my environment:

Even worth, I couldn't re-edit already-filled nodes.

ericelliott commented 4 years ago

Looks like there is a race condition. If I enter some text too quickly, the whole screen goes white and I need to refresh to get the editor working again.

If I wait a bit before trying to enter text, I can get one character working in Safari.

The editor is working great for me in Chrome and Brave.

andyfreeyy commented 3 years ago

same thing happen to me

drocta commented 3 years ago

Not sure if this is the same issue or not. It sounds similar at least. On firefox on windows, whenever I type anything, the page goes white. I think it is because the div with id root gets style=display:none set, because when I remove that, everything is visible again, until I try to type anything else. If I load a diagram from the url, or from the parse option, the page also goes white. When I remove the display:none from the root div, it all becomes visible again, and it seems to have loaded everything correctly, and renders the text correctly (but sometimes not including the grid or the nodes, just the text on the arrows). Panning or even resizing the inspect-element box seems to tend to set the style back to display:none and render the page white, It works fine in chrome for me.