search

yithemes / yith-proteo

Proteo is a sleek, modern and “Gutenberg-friendly” e-commerce theme. Developed with a beautiful UI and a minimal design, is perfect for each kind of shop. Easy to manage and to customize, Proteo is the best solution if you want a complete e-commerce template and start quickly to sell your products with WooCommerce without a technical knowledge. Use it also for corporate site or a blog: there are no limits about what you can do with a beautiful and usable theme like this!
https://proteo.yithemes.com
GNU General Public License v2.0
32 stars 4 forks source link

widget_yith_proteo_account_widget icon is an img #17

Closed EugenioPetulla closed 3 years ago

EugenioPetulla commented 3 years ago

Actually is impossible to dinamically change the color of this icon because it's an img tag and the only manipulatoin we can apply is a filter property, not the ideal use case here.

https://github.com/yithemes/yith-proteo/blob/6c63ce5d88c641f2e8840dd48391b41bf706fc04/inc/widgets/class-yith-proteo-account-widget.php#L60

I suggest to change the icon with the font-icon version or just inject the full SVG code in the HTML so we can use the fill css property in order to dinamically change the color according to the selected theme option.

Ref: https://developer.mozilla.org/en-US/docs/Web/SVG/Tutorial/Fills_and_Strokes#using_css

Actual issue example here:

menu-issue-1

francgrasso commented 3 years ago

Hi there, issue fixed with commit https://github.com/yithemes/yith-proteo/commit/fc828f5748e41acd59127ebc5d9d411f87330110

francgrasso commented 3 years ago

Please provide feedback in order to close this issue 👍

EugenioPetulla commented 3 years ago

Fix tested and confirmed! :D