search

yithemes / yith-proteo

Proteo is a sleek, modern and “Gutenberg-friendly” e-commerce theme. Developed with a beautiful UI and a minimal design, is perfect for each kind of shop. Easy to manage and to customize, Proteo is the best solution if you want a complete e-commerce template and start quickly to sell your products with WooCommerce without a technical knowledge. Use it also for corporate site or a blog: there are no limits about what you can do with a beautiful and usable theme like this!
https://proteo.yithemes.com
GNU General Public License v2.0
32 stars 4 forks source link

Fix CLS search icon #31

Closed Mte90 closed 3 years ago

Mte90 commented 3 years ago

with the fixed size there isn't anymore CLS

Mte90 commented 3 years ago

Also the code on https://github.com/yithemes/yith-proteo/blob/master/js/theme.js#L334 generate a CLS of 0.14 that means basically get an alert on PageSpeed.

francgrasso commented 3 years ago

An improved version of this patch is this one that dinamically changes the width of the element using rems. width: 1.6rem; For this reason I'm closing this pull request and add a different fix to the theme in this commit https://github.com/yithemes/yith-proteo/commit/915acc7cd06c85347ad0bacfe9f7887064c0431c

For the other comment, I will check it asap.