search

yitsushi / go-misskey

Misskey Go SDK
GNU General Public License v3.0
48 stars 12 forks source link

Fix formRequest and update linter #83

Closed yitsushi closed 3 years ago

yitsushi commented 3 years ago

The original PR from @itsalltoast would fix on service layer, but in the future we can face the same issue when we add new endpoints, so decided to fix it in the "core" with checking if it's a pointer or not.

Now we have tests to cover formRequest endpoints. Both create file and create file from URL have test.

As an addition, linters are up to date and all offenses are fixed.

original PR: https://github.com/yitsushi/go-misskey/pull/82/files

resolves #81

coveralls commented 3 years ago

Coverage Status

Coverage increased (+1.03%) to 80.065% when pulling 16ca8c4550c40697f8f1239d8e9e1bce2a05cb37 on fix-81 into 79312a47e16b7a155a30a9123dc78eb7ed6ae66e on main.