yiuyao0516 / confogl

Automatically exported from code.google.com/p/confogl
0 stars 0 forks source link

CVars added to the confogl CVar system are loaded before the server.cfg #144

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Normally, confogl.cfg is executed after the server.cfg to make sure that 
competitive settings in there get not overridden by (bad) settings in the 
server.cfg

But on mapchange/-restart, CVars "added" to confogl with the confogl_addcvar 
commmand get set before the server.cfg, and will then be overridden if theres 
duplicates in the server.cfg
They should be set after the server.cfg/confogl.cfg was executed.

(Example:
I use lerptracker.smx at all times on my server to prevent abuse and check 
players' lerps, but in my server.cfg I set sm_announce_lerp to "2" since I 
don't need public lerp announcements every time someone joins, it's sufficient 
to me to know of changes, that they are kicked if their lerp is above 100 and 
that I can check lerps manually.

Now when I load the Fresh config, which has confogl_addcvar sm_announce_lerp 1, 
it gets overridden by the setting in the server.cfg, resulting in a wrong 
setting for matches.)

Original issue reported on code.google.com by Dynastic...@googlemail.com on 23 Apr 2011 at 4:15

GoogleCodeExporter commented 8 years ago
Issue identified: When switching to the cvarsettings system, cvar changes were 
enforced after server.cfg by being triggered OnMapStart and running in the next 
game frame (next command buffer flush).

Fix: Switch cvar setting enforcement to be triggered OnConfigsExecuted();
A fix is included in latest hg tip.

Needs testing.

Original comment by prodigysim@gmail.com on 23 Apr 2011 at 8:44