yiwensong / coinbasepro-python

The unofficial Python client for the Coinbase Pro API
MIT License
0 stars 2 forks source link

unit tests should not be calling the coinbase API #2

Closed yiwensong closed 5 years ago

yiwensong commented 5 years ago

almost all of the unit tests are making actual calls to the coinbase API. this is bad practice and should be avoided. this also causes us to get rate limited during our automatic deployment sometimes (https://travis-ci.org/yiwensong/coinbasepro-python/jobs/442554704), which takes a lot of time to solve.

we should be mocking out the requests instead and just be checking that we are able to interface with the expected response.

yiwensong commented 5 years ago

4 removed all the stuff that called the coinbase API.