yiwern5 / pe

0 stars 0 forks source link

add_schedule did not check for start and end date time #6

Open yiwern5 opened 6 months ago

yiwern5 commented 6 months ago

Output for: add_schedule title/TITLE d/DESCRIPTION end/2024-04-13 21:00 start/2024-04-13 22:00:

image.png

It might be better to check the end time is later than start time for better user experience by handling error in user input :)

soc-se-bot commented 6 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Event Start Time can be after End Time

Currently, can event can be scheduled such that its start time is after its end time. There is no validation of the input start and end times of an event.

Steps to reproduce:

  1. Input the command add_schedule title/Meeting d/CS2103T start/2024-04-14 21:00 end/2024-04-13 22:00

Expected result: The event should not be schedulable.

Actual Result: Such an event is scheduled, refer to events 3 and 4.

image.png


[original: nus-cs2103-AY2324S2/pe-interim#3878] [original labels: type.FeatureFlaw severity.High]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We reject this bug. The reasons are as follows:

  • The user is responsible to ensure that the inputs are valid (i.e., that the start time can only be before the end time). Moreover, this qualifies as a "problem caused by extreme user behavior" by the same line of reasoning.

  • Our reasoning is also based on https://github.com/nus-cs2103-AY2324S2/forum/issues/680.

    Items for the Tester to Verify

    :question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** I believe this issue can be considered as NotInScope as prof has mentioned that this feature is a nice to have enhancement, which could be implemented in the future, as fixing the feature flaw is essential for the app to be reasonably useful. ![image.png](https://raw.githubusercontent.com/yiwern5/pe/main/files/d1ac1602-a039-451e-a2de-cdd7b4363e1b.png) ![image.png](https://raw.githubusercontent.com/yiwern5/pe/main/files/a2318f64-b0d5-413b-929d-f7c0e29f078c.png) ![image.png](https://raw.githubusercontent.com/yiwern5/pe/main/files/2323f219-b310-43db-98b7-1d7d5cf8a50c.png)
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]