yixiann / pe

0 stars 0 forks source link

Overzealous input validation of phone number prevents "-" and other symbols common in phone numbers. #4

Open yixiann opened 1 year ago

yixiann commented 1 year ago

It is better to warn rather than to block when inputs are not compliant with the expected format, unless accepting such inputs can hinder the operations of the software. Allowing such flexibility can in turn allow the user to use the software in ways you didn't even anticipate while overzealous rejection of inputs can annoy the user.

image.png

This is a low severity as there are ways to circumvent the use of a hypen but it still prevents certain phone numbers (esp country codes) from being keyed in.

soc-se-bot commented 1 year ago

Team's Response

Allowing phone numbers with hyphens and spaces can be good but is not essential in the current iteration. Currently, the error message describes the expected input format concisely. Even current products such as iPhone contacts app do not allow spaces and hyphens in phone numbers.

Moreover, it is unlikely that our target users would need to store phone numbers with country codes as they are unlikely to participate in group buys together if they live in different regions.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]