search

yixinL7 / BRIO

ACL 2022: BRIO: Bringing Order to Abstractive Summarization
330 stars 43 forks source link

Hard coded max_length, it should be `args.total_len`. #8

Closed CheaSim closed 2 years ago

CheaSim commented 2 years ago

https://github.com/yixinL7/BRIO/blob/a32b78e87fb8282847ee8c1e17856c8dad8d906c/main.py#L287

It should be like.

dct = tok.batch_encode_plus(slines, max_length=args.total_len, return_tensors="pt", padding="max_length", truncation=True)
yixinL7 commented 2 years ago

Changed! Thanks for the advice!