search

yixuan / spectra

A header-only C++ library for large scale eigenvalue problems
https://spectralib.org
Mozilla Public License 2.0
745 stars 131 forks source link

Davidson Space Size #125

Closed shivupa closed 3 years ago

shivupa commented 3 years ago

This allows the user to set initial and maximum search spaces

shivupa commented 3 years ago

Sorry I will fix this

codecov-commenter commented 3 years ago

Codecov Report

Merging #125 (5c8d57a) into master (148d019) will increase coverage by 0.0%. The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #125   +/-   ##
======================================
  Coverage    92.0%   92.1%           
======================================
  Files          45      45           
  Lines        2137    2140    +3     
======================================
+ Hits         1968    1971    +3     
  Misses        169     169
Impacted Files Coverage Δ
include/Spectra/DavidsonSymEigsSolver.h 100.0% <100.0%> (ø)
include/Spectra/JDSymEigsBase.h 89.1% <100.0%> (+0.2%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 148d019...5c8d57a. Read the comment docs.

yixuan commented 3 years ago

Looks great! I'll take a look and maybe @JensWehner also has some comments?

yixuan commented 3 years ago

I think it is good to merge. Thanks!

JensWehner commented 3 years ago

Sorry, just saw it now.