search

yixuan / spectra

A header-only C++ library for large scale eigenvalue problems
https://spectralib.org
Mozilla Public License 2.0
745 stars 131 forks source link

Logging #131

Open shivupa opened 3 years ago

shivupa commented 3 years ago

This implements a virtual Logging class which can be implemented by the user to log each iteration. This implements the proposed implementation "A" on #103.

The added tests are very simple and demonstrate an example of the derived logging class.

Closes #103

codecov-commenter commented 3 years ago

Codecov Report

Attention: Patch coverage is 96.96970% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 92.4%. Comparing base (3af5641) to head (a91f594).

:exclamation: Current head a91f594 differs from pull request most recent head 88c3b30

Please upload reports for the commit 88c3b30 to get more accurate results.

Files Patch % Lines
include/Spectra/JDSymEigsBase.h 88.8% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #131 +/- ## ======================================== - Coverage 93.2% 92.4% -0.9% ======================================== Files 45 46 +1 Lines 2400 2253 -147 ======================================== - Hits 2239 2082 -157 - Misses 161 171 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

shivupa commented 3 years ago

Thanks for the quick review and the advice!

shivupa commented 3 years ago

@JensWehner If you could take another pass I'd appreciate it!