search

yizhong187 / pe

0 stars 0 forks source link

Inability to add multiple patients or doctors with same name #2

Open yizhong187 opened 3 days ago

yizhong187 commented 3 days ago

To reproduce:

  1. Do add-doctor n/Jane Doe p/98765432 e/janedoe@example.com a/123 Clementi Ave 3 s/Orthopedics
  2. Do add-doctor n/Jane Doe p/98765432 e/janedoe@example.com a/123 Clementi Ave 3 s/Orthopedics again.

Result: Cannot be added as it is considered a duplicate contact. However, many names are rather common in Singapore, such as Tan Jun Jie or Ryan Ng etc., and it will seriously impact the user experience if duplicates of such names is not allowed. Additionally, there is no workaround possible, such as adding a number after the name for duplicates as numbers are forbidden within the name field as well.

nus-pe-script commented 11 hours ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

As a team, we agree that this is indeed a feature flaw.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unable to add doctors and patients of same names but different contact details

While the UG did state that the doctor and patient names are unique, there always exist a possibility that doctors and patients may share the same name as I have seen it before. It will be good to take into account this possibility or it may be considered as overzealous validation. Especially that this is a medical app, preciseness of names are extremely important for official documents and medicine dispense.

image.png

how to replicate: add a doctor with same name but different contact details. add-doctor n/Mark Tong p/73920472 e/mt@example.com a/456 Clementi Ave 3 s/Cardiology t/colleague

[original: nus-cs2103-AY2425S1/pe-interim#2659] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Changing bug severity from Medium to Low

As a team, we agree that this is indeed a feature flaw. However, we do believe that this inconvenience/issue would only come up in rare occasions as clinics would most likely save a patient's/doctor's full name and it is very rare for them to have exactly same full names. Hence, this situation is rare (though not impossible).

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your reason]