search

yjbanov / butterfly

A web framework for Dart based on Flutter's widget model
Apache License 2.0
157 stars 13 forks source link

Example implementation of new widget concept (WIP) #24

Closed jonahwilliams closed 7 years ago

jonahwilliams commented 7 years ago

This is not a complete implementation - I mostly focused on the API and not making it efficient (everything is still backed by Element).

yjbanov commented 7 years ago

Wow, you've explored quite a bit here! I've been working in this direction too, and the good news is there isn't too much overlap with what I've been working on, which is a collection of abstract classes to help build building blocks such as event arenas and layouts. I'll upload a PR and let's sit down and talk about how we can reconcile these two.

yjbanov commented 7 years ago

Here it is: https://github.com/yjbanov/butterfly/pull/25

yjbanov commented 7 years ago

With #25 the new classes - Column, Row, Anchor - could be based on ElementBase/SingleChildElementBase, and EventArena on Decoration. But I'm also OK with starting with something and refactoring later. So, LGTM.

yjbanov commented 7 years ago

Has this been superseded by https://github.com/yjbanov/butterfly/pull/27? Should we close this?

jonahwilliams commented 7 years ago

Yeah let's close this, it will be easier to make the changes in smaller prs