yjhp1016 / taichi_LBM3D

A 3D sparse LBM solver implemented using Taichi
MIT License
268 stars 36 forks source link

An error report #19

Closed Ruoyu66666 closed 7 months ago

Ruoyu66666 commented 11 months ago

Hi,

This is Ruoyu. I found a small issue in the function meq_vec: @ti.func def meq_vec(rho_local,u): out = ti.Vector([0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0]) out[0] = rho_local; out[3] = u[0]; out[5] = u[1]; out[7] = u[2]; out[1] = u.dot(u); out[9] = 2u.xu.x-u.yu.y-u.zu.z; out[11] = u.yu.y-u.zu.z out[13] = u.xu.y; out[14] = u.yu.z; out[15] = u.x*u.z return out

All the non-zero meq component should have density component, but the meq[k] except for meq[0] does not contain rho_local.

Regards,

Ruoyu

Ruoyu66666 commented 11 months ago

Also, a few components of meq is missed out, such as meq[8], meq[12], etc.

yjhp1016 commented 11 months ago

Hi, Ruoyu,

Thanks for your comments, I implement meq following the paper in the attachment. the missing meq[x] are already defined as 0.0 at the beginning of the function: out = ti.Vector([0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0])

Thanks

Jianhui

On Tue, 12 Sept 2023 at 03:09, Ruoyu66666.github.io < @.***> wrote:

Also, a few components of meq is missed out, such as meq[8], meq[12], etc.

— Reply to this email directly, view it on GitHub https://github.com/yjhp1016/taichi_LBM3D/issues/19#issuecomment-1714858282, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJEDKQGL2XLKQNMXJX5H5S3XZ674LANCNFSM6AAAAAA4UE357A . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Ruoyu66666 commented 11 months ago

Hi Jianhui,

Thanks for your reply. What is the paper you are referring to? The attachment is not seeable.

Regards,

Ruoyu

yjhp1016 commented 11 months ago

Here it is:

Ahrenholz, B., et al. "Prediction of capillary hysteresis in a porous material using lattice-Boltzmann methods and comparison to experimental data and a morphological pore network model." Advances in Water Resources 31.9 (2008): 1151-1173.

On Wed, 13 Sept 2023 at 01:25, Ruoyu66666.github.io < @.***> wrote:

Hi Jianhui,

Thanks for your reply. What is the paper you are referring to? The attachment is not seeable.

Regards,

Ruoyu

— Reply to this email directly, view it on GitHub https://github.com/yjhp1016/taichi_LBM3D/issues/19#issuecomment-1716759112, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJEDKQFETLUC6URA3CCG7HTX2D4OTANCNFSM6AAAAAA4UE357A . You are receiving this because you commented.Message ID: @.***>

Ruoyu66666 commented 11 months ago

Thank you Jianhui, I'll check it out.