search

yjmantilla / sovabids

A python package for the automatic conversion of EEG datasets to the BIDS standard, with a focus on making the most out of metadata.
https://sovabids.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
9 stars 3 forks source link

Dealing with untouchable fields mne-bids writes #15

Open yjmantilla opened 3 years ago

yjmantilla commented 3 years ago

So this issue is about some fields mne-bids writes as some hard-coded default values. In example the EEG reference field is hard coded to be 'n/a' or something of the sort.

As of now what Im doing is that after mne-bids makes the eeg sidecar json , I read it and replace the aforementioned field with the value the user gives me but this is rather cumbersome.

Ideally mne-bids should provide an API to set these fields with custom values instead of hard-coded ones, until them we are stuck with replacing whatever mne-bids did.

So the options are:

What should we do?

stebo85 commented 3 years ago

Dear @yjmantilla - I would open a discussion in mne-bids and ask what they think about a pull request from you to change this behaviour. If this is too involved and has too many on-flow effects for them, your workaround and rewrite it sounds ok too me.