search

yjmantilla / sovabids

A python package for the automatic conversion of EEG datasets to the BIDS standard, with a focus on making the most out of metadata.
https://sovabids.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
9 stars 3 forks source link

Doing an environment file #27

Open yjmantilla opened 3 years ago

yjmantilla commented 3 years ago

@DavidjWhite33 commented that:

One thing I wonder relating to the note you make below about installing ‘on a clean environment’ – I wonder if a simple pathway to help with development and subsequent expansion to more users would be to follow the mne-python approach of installing via a conda environment?

I agree with this. I think one of the issues with python packages is that they can break because of the dependencies' updates. In that sense I think having an environment or requirements file that also says the last version of the dependencies the package worked with would be useful.

yjmantilla commented 3 years ago

relevant https://stackoverflow.com/questions/48787250/set-up-virtualenv-using-a-requirements-txt-generated-by-conda

https://medium.com/swlh/setting-up-a-conda-environment-in-less-than-5-minutes-e64d8fc338e4

civier commented 3 years ago

Hello @DavidjWhite33 https://github.com/DavidjWhite33 and Yorguin,

Are both of you work on VNM? If yes, maybe it's time we will roll out the standard conda environment for VNM, and make sure it's BIDScoin and MNE-python ready? If not, is there anything preventing you from working through VNM?

Best, Oren

On Tue, Jul 27, 2021 at 9:57 AM Yorguin José Mantilla Ramos < @.***> wrote:

relevant https://stackoverflow.com/questions/48787250/set-up-virtualenv-using-a-requirements-txt-generated-by-conda

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/yjmantilla/sovabids/issues/27#issuecomment-887105811, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB7FUIZAZXRU5CRI247ZFDLTZXY4XANCNFSM5ARNWYLQ .

stebo85 commented 3 years ago

I would not make this dependent on VNM - it should be a standard conda or pip environment that can be reproduced in any python setup. There is no standard conda environment in VNM and will not exist any time soon.

DavidjWhite33 commented 3 years ago

@civier I have not done any sovabids testing using VNM. If a sovabids conda env is set up, I am happy to give a go on VNM (and elsewhere).

yjmantilla commented 3 years ago

@civier

Are both of you work on VNM?

At the start of the development I did it with the VNM, nevertheless I was more comfortable with the development with my windows desktop. I figured the package should work in the VNM since the test of the CI worked.

I would not make this dependent on VNM - it should be a standard conda or pip environment that can be reproduced in any python setup.

I agree with this

The main reason I have not done the environment file yet is because I dont want set the environment manually, requiring me to update it everytime I change something. I mainly want to have some process that saves the last environment sovabids was known to work so that if some package breaks some functionality, the user can install that environment that had the working versions of the packages.