Small GUI issues - Githubissues

yjmantilla / sovabids

A python package for the automatic conversion of EEG datasets to the BIDS standard, with a focus on making the most out of metadata.

https://sovabids.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

9 stars 3 forks source link

Small GUI issues #40

Open civier opened 3 years ago

civier commented 3 years ago

I tested the GUI. It works really well. Congratulations!

Some small things that can be improved:

[x] When editing the mapping files, it should say "Modifying individual participant mapping file:" rather than "Modifying rules file:".
[x] Downloaded zip file doesn't have a .zip extension (no extension at all)
[ ] Files within downloaded zip file have the path home/neuro/sovabids/front/app/_convert/* when sovabids is installed in /home/neuro/sovabids, so I guess only the initial slash is removed from the paths (when in reality, home/neuro/sovabids/front/app/_convert/ should have been removed). Maybe because I'm running it on Linux rather than Windows?

yjmantilla commented 3 years ago

@civier Regarding the second point Im not sure what is happening, I just tested the GUI and at the download it shows:

That is, it has the .zip extension. Is this an linux-only issue?

yjmantilla commented 3 years ago

For the download we use:


    response = Response(s.getvalue(), content_type = "application/x-zip-compressed")

So is possible that some browsers identify the content type and add the .zip by themselves. The filename is missing too so I guess that my browser just names it as 'downloads'.

I will inquiry in the matter

yjmantilla commented 3 years ago

@civier in the last version of the front I think I fixed the filename issue, let me know if it is resolved on your end

yjmantilla commented 3 years ago

Files within downloaded zip file have the path home/neuro/sovabids/front/app/_convert/* when sovabids is installed in /home/neuro/sovabids, so I guess only the initial slash is removed from the paths (when in reality, home/neuro/sovabids/front/app/_convert/ should have been removed). Maybe because I'm running it on Linux rather than Windows?

@civier Could you provide a snapshot of where and/or how are you seeing this. Im not sure what is the problem. Is it mainly an aesthetic issue regarding not having the '/' at the start in linux or does this affects the zip file? Are you able to decompress it ?

yjmantilla commented 3 years ago

For the first issue of renaming the mapping annotation, here is what will currently look like:

civier commented 3 years ago

No. It is not an aesthetic issue. I CAN extract the files, but they are all extracted to CURRENT_DIR/home/neuro/sovabids/front/app/_convert/* (CURRENT_DIR being the working directory)

Because /home/neuro/sovabids/front/app/_convert/* is probably where the converted files are kept on the server where the GUI is running, I assume it's a bug of some sort.

yjmantilla commented 3 years ago

Ahh I understand the issue now. In windows this doesn't happen or at least when I extract with 7z (i just press the extract here dialog). I will need to dig in this matter then