yjose / reactjs-popup

React Popup Component - Modals,Tooltips and Menus —  All in one
https://react-popup.elazizi.com/
MIT License
1.8k stars 207 forks source link

Unreachable lines of code #308

Open mDeram opened 2 years ago

mDeram commented 2 years ago

Version

v2.0.5

Issue

src/hooks.tsx have unreachable lines of code in return statements. In each hook return statement, this line can never get called:

if (!active) return;

because in the beginning of each useEffect hooks there is the same line. The value of "active" variable does not change in the hook, meaning that "active" is falsy in the beginning of the hook, the hook will return before reaching the last return statement of each hook.