See that test named add to history ignore with append transaction plugin has failed
Expected behavioraddToHistory: false should be respected if it comes from appendedTransaction. Root transaction should not appear on the undo/redo stack, and undoing/redoing should not have any affect.
Actual behavior
Transaction is added onto undo stack.
Environment Information
Browser, Microsoft Edge 116.0.1938.76 (Official build) (arm64)
Describe the bug
ySyncPlugin
ignoresaddToHistory: false
ofappendedTransaction
thus root transaction gets added onto undo/redo stack.To Reproduce Steps to reproduce the behavior:
npm run test
add to history ignore with append transaction plugin
has failedExpected behavior
addToHistory: false
should be respected if it comes fromappendedTransaction
. Root transaction should not appear on the undo/redo stack, and undoing/redoing should not have any affect.Actual behavior Transaction is added onto undo stack.
Environment Information
y-prosemirror
v1.2.1yjs
v13.6.7Additional context Original
prosemirror-history
plugin does indeed checkappendedTransaction
and inspects for possibleaddToHistory: false
as demonstrated here https://github.com/ProseMirror/prosemirror-history/blob/40d274a74d0fc0787aeca03634a64d0c78f18a50/src/history.ts#L277C15-L277C15