search

yjs / y-prosemirror

ProseMirror editor binding for Yjs
https://demos.yjs.dev/prosemirror/prosemirror.html
MIT License
339 stars 118 forks source link

support marks on element nodes #63

Open BrianHung opened 3 years ago

BrianHung commented 3 years ago

https://github.com/yjs/y-prosemirror/issues/47

BrianHung commented 3 years ago

An alternative serialization method might be to just use setAttribute('marks', node.marks) to distinguish between attrs and marks.

This would also allow marks to retain its expected properties of being an array (which help with https://github.com/yjs/y-prosemirror/pull/52), and we wouldn't also have to rely on schema to tell if something is a mark or attrs.

Bajena commented 2 months ago

Hi @dmonad would there be any chance you could take a look at this PR? It'd help us a lot to solve some inconsistencies. Thank you 🙇