Update current.cursor references to current[cursorStateField]?

yjs / y-prosemirror

ProseMirror editor binding for Yjs

https://demos.yjs.dev/prosemirror/prosemirror.html

MIT License

355 stars 124 forks source link

Update current.cursor references to current[cursorStateField]? #86

Open milesingrams opened 2 years ago

milesingrams commented 2 years ago

Not sure if this was intended, but since the cursorStateField is customizable I figured the references to current.cursor should be changed to current[cursorStateField]. I may not understand the code fully though so apologies if this is there for a reason.

https://github.com/yjs/y-prosemirror/blob/984175f7fd7960b1478f10370829659f001ccd3b/src/plugins/cursor-plugin.js#L127-L132

DAlperin commented 2 years ago

This is fixed by https://github.com/yjs/y-prosemirror/pull/88

andrictham commented 4 months ago

See #159 for an attempted fix for this.