Extract determining the attributes used for the selection into a configurable "selection builder"

yjs / y-prosemirror

ProseMirror editor binding for Yjs

https://demos.yjs.dev/prosemirror/prosemirror.html

MIT License

335 stars 116 forks source link

Extract determining the attributes used for the selection into a configurable "selection builder" #94

Closed ankon closed 2 years ago

ankon commented 2 years ago

This is modelled similar to the existing "cursor builder"; note that with this change the selection is now tagged with the ProseMirror-yjs-selection class as well.

See https://github.com/yjs/y-prosemirror/pull/55#issuecomment-1055169237; I'll would propose to close that PR in favor of this one.

ankon commented 2 years ago

https://github.com/yjs/y-prosemirror/pull/94/checks?check_run_id=5373099760 doesn't seem to be related to my changes?

dmonad commented 2 years ago

Great PR, thank you!