yjs / y-webrtc

WebRTC Connector for Yjs
MIT License
448 stars 109 forks source link

fix: incorrect generated type of `WebrtcProvider` constructor #38

Closed exuanbo closed 1 year ago

exuanbo commented 2 years ago

Fixes: https://github.com/yjs/y-webrtc/issues/29

Before:

Screen Shot 2022-07-14 at 8 19 58 PM

After:

Screen Shot 2022-07-14 at 8 21 31 PM

douira commented 1 year ago

I've also noticed this issue. Since I can't see how this would be a breaking change (since the type is being loosened) I would appreciate if this could be merged.

djmaze commented 1 year ago

Also experiencing this problem. Please merge this.

dmonad commented 1 year ago

Thanks for the PR & sorry for the delay. I'll publish a new release shortly..