Incorrect lib0 peerDependency version

yjs / y-websocket

Websocket Connector for Yjs

https://docs.yjs.dev/ecosystem/connection-provider/y-websocket

MIT License

497 stars 256 forks source link

Incorrect lib0 peerDependency version #118

Closed mifopen closed 2 years ago

mifopen commented 2 years ago

Looks like you need to set lib0 peerDependency to at least 0.2.51. Otherwise, passing provider as origin parameter of publish function doesn't make any effect and messages are handled by the "origin" instance as well. As a result,the "origin" instance handles the final awareness update on destroying/disconnecting the provider and thus holding itself in the "on" state for others on reconnection :)

_{Huly®: YJS-529}

dmonad commented 2 years ago

I'm sorry, I don't understand this bug report. How do I reproduce this? lib0 is already a dependency of y-websocket and I don't think it makes sense to add it as a peerDependency.

dmonad commented 2 years ago

Ah, so I guess you mean to bump lib0 because the broadcastchannel has a new feature that doesn't exist in the older versions of lib0. Yeah I can do that.