canadaduane
commented
4 years ago I need getYDoc as it returns null when the doc doesn't exist (as opposed to findorcreate which never returns null).
Moving to another function outside of the persistence object would be fine. It just made sense to have it there because I thought it should only exist with persistence turned on... But now that I think about it, we could generalize it so it turns the ydoc in memory only if persistence is off.
On Sat, Oct 10, 2020, 9:14 AM Kevin Jahns notifications@github.com wrote:
@dmonad commented on this pull request.
In bin/utils.js https://github.com/yjs/y-websocket/pull/32#discussion_r502800565:
ldb.storeUpdate(docName, update)}) },
- writeState: async (docName, ydoc) => {}
- writeState: async (docName, ydoc) => {},
- // Gets a Y.Doc by name, whether in memory or on disk
- getYDoc: async (docName) => {
I think that findOrCreateDoc should be preferred as it will also work when another persistence layer is defined.p
The idea of the persistence object is that it only has two properties: bindState and writeState.
Should we remove mutualSync and getYDoc or outsource them to a different function?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/yjs/y-websocket/pull/32#pullrequestreview-506104562, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAABAJV5NTH5LMPU5VCWOTSKB24FANCNFSM4SJIKUHA .
dmonad
Provides one function for synchronized access to Y.Doc documents in the
y-websocketserver:getOrCreateDocThis function can be used downstream by other server components to get or create stored documents, whether they are on-disk only, or in-memory.
This relates to discussion here about allowing a little more access to the ydb-synced documents in general so that custom requirements (like truncating and other unsupported features) can be developed on top of Yjs.
Huly®: YJS-783