The `getContent` method references the method `getXmlElement` which does not appear to exist. - Githubissues

yjs / y-websocket

Websocket Connector for Yjs

https://docs.yjs.dev/ecosystem/connection-provider/y-websocket

MIT License

467 stars 251 forks source link

The `getContent` method references the method `getXmlElement` which does not appear to exist. #86

Open chanced opened 2 years ago

chanced commented 2 years ago

Checklist

[X] Are you reporting a bug? Use github issues for bug reports and feature requests. For general questions, please use https://discuss.yjs.dev/

Describe the bug

the function getContent references getXmlElement on a Y.Doc which does not appear to exist.

https://github.com/yjs/y-websocket/blob/caa6304ba30c0e6d5921e735470f6470b045cb6a/bin/callback.js#L73

https://github.com/yjs/yjs/blob/dc9717ecd0650315d87129cff795dc5116f8bcf2/src/utils/Doc.js

To Reproduce I'm not sure that code branch can ever be reached but I wanted to let you know regardless.

Environment Information

y.js 13.5.6 per y-websocket's dependency
y-websocket - latest

_{Huly®: YJS-512}

dmonad commented 2 years ago

Right, thanks! We should adopt this to ydoc.get(objName, Y.XmlElement).