Please save me some time and use the following template. In 90% of all issues I can't reproduce the problem because I don't know what exactly you are doing, in which environment, or which y-* version is responsible. Just use the following template even if you think the problem is obvious.
Checklist
[x] Are you reporting a bug? Use github issues for bug reports and feature requests. For general questions, please use https://discuss.yjs.dev/
[x] Try to report your issue in the correct repository. Yjs consists of many modules. When in doubt, report it to https://github.com/yjs/yjs/issues/
Describe the bug
One can crash y-websocker server by sending over wire number greater than 2*2**31.
To Reproduce
start the server: node ./front/node_modules/y-websocket/bin/server.js
open websocket connection: websocat ws://localhost:1234
send 4294967296 (confirm with newline)
send 4294967297
Expected behavior
No exceptions and no crash.
Environment Information
node version 17.3.0
y-websocket version 1.3.18
Additional context
Idk whether this is problem related to ws or y-websocket. Unfortunately I currently have no time to investigate it further. I'm reporting just in case I forget about it in future.
BTW I suppose y-websocket isn't production-grade software right now, but maybe we can at least not crash whole server upon receiving garbage.
Checklist
Describe the bug One can crash
y-websockerserver by sending over wire number greater than2*2**31.To Reproduce
node ./front/node_modules/y-websocket/bin/server.jswebsocat ws://localhost:12344294967296(confirm with newline)4294967297Expected behavior No exceptions and no crash.
Environment Information
Additional context Idk whether this is problem related to
wsory-websocket. Unfortunately I currently have no time to investigate it further. I'm reporting just in case I forget about it in future.BTW I suppose
y-websocketisn't production-grade software right now, but maybe we can at least not crash whole server upon receiving garbage.And obligatorily: much thanks for your work!!