search

yjs / yjs-demos

A collection of demos for Yjs
https://demos.yjs.dev
The Unlicense
729 stars 120 forks source link

monaco-editor collaboration seems to be broken with y-js 13.3.0 (latest), works fine with 13.0 #41

Closed stefan-egorov closed 4 years ago

stefan-egorov commented 4 years ago

Describe the bug: When using monaco-demo with latest y-js version, user's cursors are incorrectly updated. monaco-bug Things get really off with both typing at the same time.

To Reproduce

  1. clone the repo. cd monanco
  2. bump yjs to latest in package.json -> ~13.3.0
  3. npm install
  4. npm start
  5. run yjs demo

Expected behavior It should work similar to yjs version 13.0.0 🤔

Environment Information

PS: The library looks really neat!

stefan-egorov commented 4 years ago

Hey @dmonad, to me this looks like a bug in awareness protocol. Can you confirm? Or am I missing something?

dmonad commented 4 years ago

Hey @stefan-egorov ,

thanks for reporting. I fixed the problem in y-monaco@0.1.0. Also see yjs/y-monaco#2