tick: added tick flavour support for passthrough fileboxes

ykaliuta / fidogate

FidoGate

GNU General Public License v2.0

12 stars 6 forks source link

tick: added tick flavour support for passthrough fileboxes #16

Closed dolikdev closed 3 years ago

dolikdev commented 3 years ago

Passthrough filebox directory name will include Hold flavour attribute (.H) when BoxesWithFlavours is defined in fidogate.conf and Tick flavour set to hold in routing.

Signed-off-by: Andriy Dzedolik dz@dolik.dev

ykaliuta commented 3 years ago

No problem, but was it enough to force update the branch instead of creating new PR? I would prefer to move the change to a helper but for the current code it's ok as is.

I'll update the commit message a bit probably, hope it's ok for you.

Thank you for the contribution!

ykaliuta commented 3 years ago

Could you please review my version?

dolikdev commented 3 years ago

The 'if' condition indeed a bit hard to follow, but otherwise looks better :)

ykaliuta commented 3 years ago

Could you test it before I push? Since unfortunately I do not have such a configuration at the moment. It's "staging" branch.

dolikdev commented 3 years ago

Built FreeBSD package & deployed on the node. Will update you on results.

dolikdev commented 3 years ago

Verified, works as expected in all 3 modes:

no PassthroughtBoxesDir key - legacy behavior;
PassthroughtBoxesDir key + tick routing hold - adds ".H" to directory name;
PassthroughtBoxesDir key + tick routing normal - no ".H" in the directory name;

ykaliuta commented 3 years ago

Verified, works as expected in all 3 modes:

* no PassthroughtBoxesDir key - legacy behavior;

* PassthroughtBoxesDir key + tick routing hold - adds ".H" to directory name;

* PassthroughtBoxesDir key + tick routing normal - no ".H" in the directory name;

Thank you!