ykang / gratis

GRATIS: GeneRAting TIme Series with diverse and controllable characteristics
https://github.com/ykang/gratis
GNU General Public License v3.0
76 stars 29 forks source link

Clash with `generate` function in `fable` for ARIMA models #33

Closed emitanaka closed 2 years ago

emitanaka commented 2 years ago

fable contains the function generate.ARIMA() so whenever fable is loaded it prefers to use fable::generate.ARIMA() for gratis::arima_model() instead of gratis::generate.Arima() causing the error like below. Perhaps the order of the classes should be swapped for arima_model() to c("forecast_ARIMA", "Arima", "ARIMA") so this won't be an issue?

library(gratis)
#> Registered S3 method overwritten by 'quantmod':
#>   method            from
#>   as.zoo.data.frame zoo
generate(arima_model())
#> # A tsibble: 1,000 x 3 [1]
#> # Key:       key [10]
#>    index key       value
#>    <dbl> <chr>     <dbl>
#>  1     1 Series 1 21.3  
#>  2     2 Series 1 -1.97 
#>  3     3 Series 1 20.3  
#>  4     4 Series 1 -2.52 
#>  5     5 Series 1 16.6  
#>  6     6 Series 1 -2.26 
#>  7     7 Series 1 14.6  
#>  8     8 Series 1 -0.454
#>  9     9 Series 1  9.97 
#> 10    10 Series 1 -0.756
#> # โ€ฆ with 990 more rows

library(fable)
#> Loading required package: fabletools
generate(arima_model())
#> Error in key_data(new_data): argument "new_data" is missing, with no default

class(arima_model())
#> [1] "forecast_ARIMA" "ARIMA"          "Arima"

Created on 2022-04-21 by the reprex package (v2.0.1)

Session info ``` r sessioninfo::session_info() #> โ”€ Session info ๐Ÿ‘ต๐Ÿฟ ๐Ÿ‘ฉโ€๐Ÿ‘งโ€๐Ÿ‘ง ๐Ÿ‡น๐Ÿ‡น โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€ #> hash: old woman: dark skin tone, family: woman, girl, girl, flag: Trinidad & Tobago #> #> setting value #> version R version 4.1.2 (2021-11-01) #> os macOS Big Sur 10.16 #> system x86_64, darwin17.0 #> ui X11 #> language (EN) #> collate en_AU.UTF-8 #> ctype en_AU.UTF-8 #> tz Australia/Melbourne #> date 2022-04-21 #> pandoc 2.17.1.1 @ /Applications/RStudio.app/Contents/MacOS/quarto/bin/ (via rmarkdown) #> #> โ”€ Packages โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€ #> package * version date (UTC) lib source #> anytime 0.3.9 2020-08-27 [1] CRAN (R 4.1.0) #> assertthat 0.2.1 2019-03-21 [1] CRAN (R 4.1.0) #> backports 1.3.0 2021-10-27 [1] CRAN (R 4.1.0) #> cli 3.2.0 2022-02-14 [1] CRAN (R 4.1.2) #> codetools 0.2-18 2020-11-04 [1] CRAN (R 4.1.2) #> colorspace 2.0-3 2022-02-19 [1] R-Forge (R 4.1.2) #> crayon 1.5.1 2022-03-26 [1] CRAN (R 4.1.2) #> curl 4.3.2 2021-06-23 [1] CRAN (R 4.1.0) #> DBI 1.1.1 2021-01-15 [1] CRAN (R 4.1.0) #> digest 0.6.29 2021-12-01 [1] CRAN (R 4.1.0) #> distributional 0.3.0 2022-01-05 [1] CRAN (R 4.1.2) #> doRNG 1.8.2 2020-01-27 [1] CRAN (R 4.1.0) #> dplyr 1.0.8.9000 2022-03-17 [1] Github (tidyverse/dplyr@8abb54b) #> ellipsis 0.3.2 2021-04-29 [1] CRAN (R 4.1.0) #> evaluate 0.14 2019-05-28 [1] CRAN (R 4.1.0) #> fable * 0.3.1 2021-05-16 [1] CRAN (R 4.1.0) #> fabletools * 0.3.2 2021-11-29 [1] CRAN (R 4.1.0) #> fansi 1.0.3 2022-03-24 [1] CRAN (R 4.1.2) #> farver 2.1.0 2021-02-28 [1] CRAN (R 4.1.0) #> fastmap 1.1.0 2021-01-25 [1] CRAN (R 4.1.0) #> foreach 1.5.2 2022-02-02 [1] CRAN (R 4.1.2) #> forecast 8.16 2022-01-10 [1] CRAN (R 4.1.2) #> fracdiff 1.5-1 2020-01-24 [1] CRAN (R 4.1.0) #> fs 1.5.2 2021-12-08 [1] CRAN (R 4.1.0) #> GA 3.2.2 2021-10-15 [1] CRAN (R 4.1.0) #> generics 0.1.2 2022-01-31 [1] CRAN (R 4.1.2) #> ggplot2 3.3.5 2021-06-25 [1] CRAN (R 4.1.0) #> glue 1.6.2 2022-02-24 [1] CRAN (R 4.1.2) #> gratis * 1.0.0 2022-04-21 [1] Github (ykang/gratis@be360c2) #> gtable 0.3.0 2019-03-25 [1] CRAN (R 4.1.0) #> highr 0.9 2021-04-16 [1] CRAN (R 4.1.0) #> htmltools 0.5.2 2021-08-25 [1] CRAN (R 4.1.0) #> httpuv 1.6.5 2022-01-05 [1] CRAN (R 4.1.2) #> iterators 1.0.14 2022-02-05 [1] CRAN (R 4.1.2) #> knitr 1.37 2021-12-16 [1] CRAN (R 4.1.0) #> later 1.3.0 2021-08-18 [1] CRAN (R 4.1.0) #> lattice 0.20-45 2021-09-22 [1] CRAN (R 4.1.2) #> lifecycle 1.0.1 2021-09-24 [1] CRAN (R 4.1.0) #> lmtest 0.9-40 2022-03-21 [1] CRAN (R 4.1.2) #> lubridate 1.8.0 2021-10-07 [1] CRAN (R 4.1.0) #> magrittr 2.0.3 2022-03-30 [1] CRAN (R 4.1.2) #> mime 0.12 2021-09-28 [1] CRAN (R 4.1.0) #> munsell 0.5.0 2018-06-12 [1] CRAN (R 4.1.0) #> mvtnorm 1.1-3 2021-10-08 [1] CRAN (R 4.1.0) #> nlme 3.1-153 2021-09-07 [1] CRAN (R 4.1.2) #> nnet 7.3-16 2021-05-03 [1] CRAN (R 4.1.2) #> pillar 1.7.0 2022-02-01 [1] CRAN (R 4.1.2) #> pkgconfig 2.0.3 2019-09-22 [1] CRAN (R 4.1.0) #> polynom 1.4-1 2022-04-11 [1] CRAN (R 4.1.2) #> promises 1.2.0.1 2021-02-11 [1] CRAN (R 4.1.0) #> purrr 0.3.4 2020-04-17 [1] CRAN (R 4.1.0) #> quadprog 1.5-8 2019-11-20 [1] CRAN (R 4.1.0) #> quantmod 0.4.18 2020-12-09 [1] CRAN (R 4.1.0) #> R.cache 0.15.0 2021-04-30 [1] CRAN (R 4.1.0) #> R.methodsS3 1.8.1 2020-08-26 [1] CRAN (R 4.1.0) #> R.oo 1.24.0 2020-08-26 [1] CRAN (R 4.1.0) #> R.utils 2.11.0 2021-09-26 [1] CRAN (R 4.1.0) #> R6 2.5.1 2021-08-19 [1] CRAN (R 4.1.0) #> Rcpp 1.0.8.3 2022-03-17 [1] CRAN (R 4.1.2) #> reprex 2.0.1 2021-08-05 [1] CRAN (R 4.1.0) #> rlang 1.0.2.9000 2022-03-17 [1] Github (r-lib/rlang@22fe9e9) #> rmarkdown 2.11 2021-09-14 [1] CRAN (R 4.1.0) #> rngtools 1.5.2 2021-09-20 [1] CRAN (R 4.1.0) #> rstudioapi 0.13 2020-11-12 [1] CRAN (R 4.1.0) #> scales 1.2.0 2022-04-13 [1] CRAN (R 4.1.2) #> sessioninfo 1.2.1 2021-11-02 [1] CRAN (R 4.1.0) #> shiny 1.7.1 2021-10-02 [1] CRAN (R 4.1.0) #> stringi 1.7.6 2021-11-29 [1] CRAN (R 4.1.0) #> stringr 1.4.0 2019-02-10 [1] CRAN (R 4.1.0) #> styler 1.6.2 2021-09-23 [1] CRAN (R 4.1.0) #> tibble 3.1.6 2021-11-07 [1] CRAN (R 4.1.0) #> tidyr 1.2.0 2022-02-01 [1] CRAN (R 4.1.2) #> tidyselect 1.1.2 2022-02-21 [1] CRAN (R 4.1.2) #> timeDate 3043.102 2018-02-21 [1] CRAN (R 4.1.0) #> tseries 0.10-50 2022-03-28 [1] CRAN (R 4.1.2) #> tsfeatures 1.0.2 2020-06-07 [1] CRAN (R 4.1.0) #> tsibble 1.1.1 2021-12-03 [1] CRAN (R 4.1.0) #> TTR 0.24.3 2021-12-12 [1] CRAN (R 4.1.0) #> urca 1.3-0 2016-09-06 [1] CRAN (R 4.1.0) #> utf8 1.2.2 2021-07-24 [1] CRAN (R 4.1.0) #> vctrs 0.4.1 2022-04-13 [1] CRAN (R 4.1.2) #> withr 2.5.0 2022-03-03 [1] CRAN (R 4.1.2) #> xfun 0.29 2021-12-14 [1] CRAN (R 4.1.0) #> xtable 1.8-4 2019-04-21 [1] CRAN (R 4.1.0) #> xts 0.12.1 2020-09-09 [1] CRAN (R 4.1.0) #> yaml 2.2.2 2022-01-25 [1] CRAN (R 4.1.2) #> zoo 1.8-10 2022-04-15 [1] CRAN (R 4.1.2) #> #> [1] /Library/Frameworks/R.framework/Versions/4.1/Resources/library #> #> โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€ ```
robjhyndman commented 2 years ago

Thanks. Fixed in https://github.com/ykang/gratis/commit/8b91044272bd9039036471314863013567fe04ad