search

ykarim / openmrs-contrib-gci-site

🌐 OpenMRS Google Code-in 2018 Website
https://ykarim.github.io/openmrs-contrib-gci-site/
Other
1 stars 6 forks source link

Design Footer #33

Closed riskycase closed 5 years ago

riskycase commented 5 years ago

Added a starting design that's in sync with the chosen theme, but I have a doubt if we'd move forward with a black and white design

Bisht13 commented 5 years ago

Hey @riskycase can you squash the commits?

Bisht13 commented 5 years ago

Hey @riskycase , can you change the commit message to something like added footer design

ykarim commented 5 years ago

Hi @riskycase , this seems good but here's some comments:

riskycase commented 5 years ago

Hey @ykarim , these are the changes I made according to your points

  • The back to top seems pointless. Users could simply scroll if they really want to. It's not really common to include this

I'm planning to leave it there for the convenience of the user

  • You're missing the mobile design
  • Since the Contact page is now renamed to Help can you reflect this?

Added both the changes

  • Also, what color is the background? It should flow with the rest of the page

I had made it opaque black according to the design but on second thoughts I've set it to 204 alpha value

ykarim commented 5 years ago

This is all good, but for the mobile design that might not fit on all screens (some phones are still small screen sizes). What do you think about having a vertically displayed set of links similar to how Square or Lyft are designed for mobile. That way the links are guaranteed to have adequate spacing. Also, what about adding a Back to Top button for mobile to keep consistency. The button may assist if the page is long in size (some pages are)

riskycase commented 5 years ago

Adding both list of links to a single column would make the footer too tall on mobile so I moved the img-links a bit closer to center and lower to try reducing the width. Besides I also tweaked the design a bit like using an opaque dark gray instead of transperant black and increasing padding between heading and links in the columns

ykarim commented 5 years ago

Resolves #32