search

ykdojo / OpenStream

OpenStream is an open-source project for creating a free tool that records screen and webcam footage simultaneously into separate files. It's designed for content creators and developed collaboratively through our community on Discord.
MIT License
107 stars 24 forks source link

Review the pull request #31 thoroughly #32

Closed ykdojo closed 7 months ago

ykdojo commented 7 months ago

31

ykdojo commented 7 months ago

I'm thinking a self-review might be a valid option here.

Steps I'd take to do this:

  1. Set up a screen recording environment, for example with Loom
  2. First, walk through which files were changed and how
  3. Then, show how it's set up and can be developed (ideally from scratch)
  4. Also explain the changes in README if you haven't yet
omar-shahid commented 7 months ago

File changes: https://www.loom.com/share/95ab427929e74174abb0ff7af5b8ea84?sid=2d899446-754e-4fda-80a6-92b9ef86f62b

Getting started: https://www.loom.com/share/d4b9cee8cce748459ab8d144e3ffd222?sid=17ea7ad4-57cc-4acc-8d97-4722919abc1d

ykdojo commented 7 months ago

Feedback on the video quality:

  1. There's a significant amount of noise. I'm not sure if it's easy to fix though. Perhaps we can add noise cancellation to OpenStream itself at some point in the future to mitigate issues like this.
  2. Would be helpful for you to speak slightly more slowly, I think. Just more clarity would be helpful.

Other than that, very cool! Thank you so much. I'll merge your PR.

omar-shahid commented 7 months ago

Thanks @ykdojo, it's my first time recording videos, thanks for the feedback!