search

ykdojo / OpenStream

OpenStream is an open-source project for creating a free tool that records screen and webcam footage simultaneously into separate files. It's designed for content creators and developed collaboratively through our community on Discord.
MIT License
105 stars 23 forks source link

Add a pull request template #7

Closed CBID2 closed 4 months ago

CBID2 commented 5 months ago

This would aid contributors on submitting their PR, especially if it’s their first time contributing to an open source project.

BlackBond06 commented 5 months ago

Hi @CBID2 @ykdojo I have made a PR for this issue, please review.

ykdojo commented 5 months ago

Add a few comments @BlackBond06

ykdojo commented 5 months ago

Closed it #19 as I mentioned as I would.

ykdojo commented 5 months ago

This would aid contributors on submitting their PR, especially if it’s their first time contributing to an open source project.

Explaining how this would be helpful specifically might be helpful to clarify the intent of this issue @CBID2.

CBID2 commented 5 months ago

This would aid contributors on submitting their PR, especially if it’s their first time contributing to an open source project.

Explaining how this would be helpful specifically might be helpful to clarify the intent of this issue @CBID2.

Sure @ykdojo. In my experience maintaining projects that use PR templates, they add context about a person's contribution(s), making it easier for us and other contributors to give effective feedback.

ykdojo commented 5 months ago

Got it. Let us know if you have a specific format / questions in mind.

CBID2 commented 5 months ago

Got it. Let us know if you have a specific format / questions in mind.

Hi @ykdojo. Here's what I came up with
pull_request_template.md

ykdojo commented 5 months ago

I think it's nice! Very simple. We can keep adding more stuff to it in the future if necessary.

ykdojo commented 5 months ago

Changes Proposed should be Changes proposed for consistency though

CBID2 commented 5 months ago

Changes Proposed should be Changes proposed for consistency though

Great @ykdojo! :) I'll do the PR right away

CBID2 commented 5 months ago

Changes Proposed should be Changes proposed for consistency though

As promised, PR is done. Check out #28

ykdojo commented 5 months ago

Added a comment on #28!